Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong service name for coredns #8811

Merged
merged 1 commit into from
May 12, 2022

Conversation

weizhoublue
Copy link
Contributor

@weizhoublue weizhoublue commented May 11, 2022

Signed-off-by: [email protected] [email protected]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

when clean up dns , it seems to use wrong service name

TASK [kubernetes-apps/ansible : Kubernetes Apps | Register coredns service annotation `createdby`] ************************************************************************************************************
task path: /home/kubespray/roles/kubernetes-apps/ansible/tasks/cleanup_dns.yml:11
fatal: [master1]: FAILED! => {
    "changed": false,
    "cmd": [
        "/usr/local/bin/kubectl",
        "--kubeconfig",
        "/etc/kubernetes/admin.conf",
        "get",
        "svc",
        "-n",
        "kube-system",
        "kube-dns",
        "-o",
        "jsonpath={ .metadata.annotations.createdby }"
    ],
    "delta": "0:00:00.105217",
    "end": "2022-05-11 14:46:12.546543",
    "invocation": {
        "module_args": {
            "_raw_params": "/usr/local/bin/kubectl --kubeconfig /etc/kubernetes/admin.conf get svc -n kube-system kube-dns -o jsonpath='{ .metadata.annotations.createdby }'",
            "_uses_shell": false,
            "argv": null,
            "chdir": null,
            "creates": null,
            "executable": null,
            "removes": null,
            "stdin": null,
            "stdin_add_newline": true,
            "strip_empty_ends": true,
            "warn": false
        }
    },
    "msg": "non-zero return code",
    "rc": 1,
    "start": "2022-05-11 14:46:12.441326",
    "stderr": "Error from server (NotFound): services \"kube-dns\" not found",
    "stderr_lines": [
        "Error from server (NotFound): services \"kube-dns\" not found"
    ],
    "stdout": "",
    "stdout_lines": []
}

Which issue(s) this PR fixes:

none

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Use correct service name for coredns when cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @weizhoublue. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and jayonlau May 11, 2022 15:04
@weizhoublue weizhoublue changed the title get wrong server name of coredns wrong server name for coredns May 11, 2022
@weizhoublue weizhoublue changed the title wrong server name for coredns wrong service name for coredns May 11, 2022
@oomichi
Copy link
Contributor

oomichi commented May 11, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 11, 2022
@cristicalin
Copy link
Contributor

Thanks for the fix @weizhoublue !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2022
@oomichi
Copy link
Contributor

oomichi commented May 12, 2022

nice catch

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, weizhoublue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit b289f53 into kubernetes-sigs:master May 12, 2022
@floryut floryut added kind/bug Categorizes issue or PR as related to a bug. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 16, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 30, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants