Skip gathering facts when reset_nodes is false #8843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
The doc[1] explains we need to specify "-e reset_nodes=false -e allow_ungraceful_removal=true" to delete offline node. However the task "Gather facts" tried to gather facts of offline node also and the task was failed. This adds a condition to skip gathering facts when reset_nodes is false on remove-node.yml. [1]: https://github.com/kubernetes-sigs/kubespray/blob/master/docs/nodes.md#3-remove-an-old-node-with-remove-nodeyml
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
Thanks @oomichi ! /lgtm |
k8s-ci-robot
added
the
lgtm
Closed
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 30, 2023
The doc[1] explains we need to specify "-e reset_nodes=false -e allow_ungraceful_removal=true" to delete offline node. However the task "Gather facts" tried to gather facts of offline node also and the task was failed. This adds a condition to skip gathering facts when reset_nodes is false on remove-node.yml. [1]: https://github.com/kubernetes-sigs/kubespray/blob/master/docs/nodes.md#3-remove-an-old-node-with-remove-nodeyml
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 23, 2023
The doc[1] explains we need to specify "-e reset_nodes=false -e allow_ungraceful_removal=true" to delete offline node. However the task "Gather facts" tried to gather facts of offline node also and the task was failed. This adds a condition to skip gathering facts when reset_nodes is false on remove-node.yml. [1]: https://github.com/kubernetes-sigs/kubespray/blob/master/docs/nodes.md#3-remove-an-old-node-with-remove-nodeyml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The doc1 explains we need to specify
to delete offline node. However the task "Gather facts" tried to gather facts of offline node also and the task was failed.
This adds a condition to skip gathering facts when reset_nodes is false on remove-node.yml.
This change comes from @acainelli's comment, thank you @acainelli!
Which issue(s) this PR fixes:
Fixes #8806
Does this PR introduce a user-facing change?: