Enable shellcheck for contrib/ #9122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
|
humm, it would be better to enable all contrib/ files I guess. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
Today we have many contributions to contrib/offline/ and some PRs contained invalid coding style for those scripts. This enables shellcheck to make such invalid coding style easily.
oomichi
force-pushed
the
enable-shellcheck-offline
branch
from
19fb248 to
01685ba
Compare
k8s-ci-robot
added
size/S
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
floryut
approved these changes
Jul 27, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
oomichi
changed the title
nolimitkun
pushed a commit
to nolimitkun/kubespray
that referenced
this pull request
Mar 19, 2023
Today we have many contributions to contrib/offline/ and some PRs contained invalid coding style for those scripts. This enables shellcheck to make such invalid coding style easily.
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jul 2, 2023
Today we have many contributions to contrib/offline/ and some PRs contained invalid coding style for those scripts. This enables shellcheck to make such invalid coding style easily.
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jul 7, 2023
Today we have many contributions to contrib/offline/ and some PRs contained invalid coding style for those scripts. This enables shellcheck to make such invalid coding style easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Today we have many contributions to contrib/offline/ and some PRs contained invalid coding style for those scripts.
This enables shellcheck to make such invalid coding style easily.
Does this PR introduce a user-facing change?: