-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace opencensus vanity url to avoid expired cert #287
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mselim00 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @mselim00! |
Hi @mselim00. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test normally want to avoid It's a transitive dependency of |
/close
|
@cartermckinnon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adds a go.mod directive then
go mod tidy
This repo has a dependency on go.opencensus.io, which has been archived since July, 2023. The certificates for that vanity URL have expired, causing downstream CI failures (and general build issues).
This is intended as a temporary fix until the dependencies here that require it can fully migrate off.
See
Edit
This is probably not safe to merge, or makes things worse anyway. Tested
go install github.com/mselim00/kubetest2@latest
and got:It seems packages that have replace directives must be installed from source (
git clone
+cd
+go install .
), which would be a breaking change for probably any downstream.