Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.2.1 #352

Closed
20 tasks done
alculquicondor opened this issue Aug 24, 2022 · 12 comments
Closed
20 tasks done

Release v0.2.1 #352

alculquicondor opened this issue Aug 24, 2022 · 12 comments
Assignees

Comments

@alculquicondor
Copy link
Contributor

alculquicondor commented Aug 24, 2022

Release Checklist

  • All OWNERS must LGTM the release proposal
  • Verify that the changelog in this issue is up-to-date
  • For major or minor releases (v$MAJ.$MIN.0), create a new release branch.
    • an OWNER creates a vanilla release branch with
      git branch release-$MAJ.$MIN main
    • An OWNER pushes the new release branch with
      git push release-$MAJ.$MIN
  • Update things like README, deployment templates, docs, configuration, test/e2e flags.
    Submit a PR against the release branch: Release 0.2 update #357
  • An OWNER prepares a draft release
    • Write the change log into the draft release.
    • Run
      make artifacts IMAGE_REGISTRY=registry.k8s.io/kueue GIT_TAG=$VERSION
      to generate the artifacts and upload the files in the artifacts folder
      to the draft release.
  • An OWNER creates a signed tag running
    git tag -s $VERSION
    and inserts the changelog into the tag description.
    To perform this step, you need a PGP key registered on github.
  • An OWNER pushes the tag with
    git push $VERSION
    • Triggers prow to build and publish a staging container image
      gcr.io/k8s-staging-kueue/kueue:$VERSION
  • Submit a PR against k8s.io,
    updating k8s.gcr.io/images/k8s-staging-kueue/images.yaml to
    promote the container images
    to production: Promote kueue v0.2.0 image kubernetes/k8s.io#4142
  • Wait for the PR to be merged and verify that the image registry.k8s.io/kueue/kueue:$VERSION is available.
  • Publish the draft release prepared at the Github releases page.
  • Add a link to the tagged release in this issue: https://github.com/kubernetes-sigs/kueue/releases/tag/v0.2.0
  • Send an announcement email to [email protected] and [email protected] with the subject [ANNOUNCE] kueue $VERSION is released
  • Add a link to the release announcement in this issue: https://groups.google.com/a/kubernetes.io/g/wg-batch/c/7Ayju9Lfg2s
  • For a major or minor release, update README.md and docs/setup/install.md
    in main branch: Update latest version #359 >
  • For a major or minor release, create an unannotated devel tag in the
    main branch, on the first commit that gets merged after the release
    branch has been created (presumably the README update commit above), and, push the tag:
    DEVEL=v0.$(($MAJ+1)).0-devel; git tag $DEVEL main && git push $DEVEL
    This ensures that the devel builds on the main branch will have a meaningful version number.
  • Close this issue

Changelog

Changes since `v0.1.0`:

### Features

- Upgrade the API version from v1alpha1 to v1alpha2. v1alpha1 is no longer supported.
  v1alpha2 includes the following changes:
  - Rename Queue to LocalQueue.
  - Remove ResourceFlavor.labels. Use ResourceFlavor.metadata.labels instead.
- Add webhooks to validate and to add defaults to all kueue APIs.
- Add internal cert manager to serve webhooks with TLS.
- Use finalizers to prevent ClusterQueues and ResourceFlavors in use from being
  deleted prematurely.
- Support [codependent resources](/docs/concepts/cluster_queue.md#codepedent-resources)
  by assigning the same flavor to codependent resources in a pod set.
- Support [pod overhead](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-overhead/)
  in Workload pod sets.
- Set requests to limits if requests are not set in a Workload pod set,
  matching [internal defaulting for k8s Pods](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#resources).
- Add [prometheus metrics](/docs/reference/metrics.md) to monitor health of
  the system and the status of ClusterQueues.
- Use Server Side Apply for Workload admission to reduce API conflicts.

### Bug fixes

- Fix bug that caused Workloads that don't match the ClusterQueue's
  namespaceSelector to block other Workloads in StrictFIFO ClusterQueues.
- Fix the number of pending workloads in BestEffortFIFO ClusterQueues status.
- Fix a bug in BestEffortFIFO ClusterQueues where a workload might not be
  retried after a transient error.
- Fix requeuing an out-of-date workload when failed to admit it.
- Fix a bug in BestEffortFIFO ClusterQueues where inadmissible workloads
  were not removed from the ClusterQueue when removing the corresponding Queue.
@alculquicondor
Copy link
Contributor Author

alculquicondor commented Aug 24, 2022

Let's start by collecting LGTMs. We are waiting on #351 to merge.

@ahg-g
Copy link
Contributor

ahg-g commented Aug 24, 2022

/lgtm

@alculquicondor
Copy link
Contributor Author

All PRs are merged now

@alculquicondor
Copy link
Contributor Author

oh, forgot to cc @kerthcet

@kerthcet
Copy link
Contributor

Maybe

  • Features:
    1. Support SSA in workload Admission.
    2. Support finalizers to clusterQueue and resourceFlavor
    3. Support internal cert management rather than introducing a third-party one like cert-manger

@kerthcet
Copy link
Contributor

Others LGTM.

@alculquicondor
Copy link
Contributor Author

I wasn't sure if those were user-visible enough, but opened a PR nevertheless #354

@alculquicondor
Copy link
Contributor Author

Back to ready :)

@ArangoGutierrez
Copy link
Contributor

/lgtm

@denkensk
Copy link
Member

/lgtm

This was referenced Aug 26, 2022
@alculquicondor alculquicondor changed the title Release v0.2.0 Release v0.2.1 Aug 26, 2022
@alculquicondor
Copy link
Contributor Author

/close
Release steps completed

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Closing this issue.

In response to this:

/close
Release steps completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants