You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
API which allows to use custom PodIndex labels for custom CRD jobs, without the incentive to use labels
reserved for kubernetes in the in-house Jobs.
Why is this needed:
the current PodIndex labels lookup only work for "known" jobs with built-in integrations: here
this will not work for in-house Jobs, unless the developers use the labels from other projects (like kubernetes.io/job-completion-index), which creates an unhealthy incentive in the long run
// PodIndexLabel indicates the name of the label indexing the pods. // For example, in the context of// - kubernetes job this is: kubernetes.io/job-completion-index// - JobSet: kubernetes.io/job-completion-index (inherited from Job)// - Kubeflow: training.kubeflow.org/replica-indexPodIndexLabel*string// SubGroupIndexLabel indicates the name of the label indexing the instances of replicated Jobs (groups)// within a PodSet. For example, in the context of JobSet this is jobset.sigs.k8s.io/job-index.SubGroupIndexLabel*string// SubGroupIndexLabel indicates the count of replicated Jobs (groups) within a PodSet.// For example, in the context of JobSet this value is read from jobset.sigs.k8s.io/replicatedjob-replicas.SubGroupCount*int32
The values could be then set when implementing the PodSets() function in the GenericJob interface via the PodSetTopologyRequest helper function like here.
Then, the API could be read from TopologyUngater, instead of the lookups.
What would you like to be added:
API which allows to use custom PodIndex labels for custom CRD jobs, without the incentive to use labels
reserved for kubernetes in the in-house Jobs.
Why is this needed:
Completion requirements:
The text was updated successfully, but these errors were encountered: