Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAS: Extend PodSetTopologyRequest API by index labels #3704

Merged
merged 2 commits into from
Dec 3, 2024
Merged

TAS: Extend PodSetTopologyRequest API by index labels #3704

merged 2 commits into from
Dec 3, 2024

Conversation

PBundyra
Copy link
Contributor

@PBundyra PBundyra commented Dec 2, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Introduces new API to the PodSetTopologyRequest
  • Adjusts integration of batchv1.Job, Jobset, Kubeflow CRDs, PodGroup for TAS rank-ordering

Which issue(s) this PR fixes:

Fixes #3663

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Extend the GenericJob interface to allow implementations of custom Job CRDs to use
Topology-Aware Scheduling with rank-based ordering.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 2, 2024
@k8s-ci-robot k8s-ci-robot requested a review from denkensk December 2, 2024 13:49
@PBundyra
Copy link
Contributor Author

PBundyra commented Dec 2, 2024

/assign @mimowo

@k8s-ci-robot k8s-ci-robot requested a review from trasc December 2, 2024 13:49
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 2, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit c8c60b3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/674ece54f84ab10008feade5

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 2, 2024
@PBundyra PBundyra force-pushed the extend-ps-topology-request branch from fe02c08 to 4bb02d4 Compare December 2, 2024 16:04
mimowo
mimowo reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I'm just wondering about MPIJob and RayJob support.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 2, 2024
mimowo
mimowo reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a5c1e9edab050661e883b44494bdf3d39eb2b238

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, PBundyra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@PBundyra PBundyra mentioned this pull request Dec 3, 2024
Closed
@mimowo
Copy link
Contributor

mimowo commented Dec 3, 2024

/release-note-edit

Extend the GenericJob interface to allow implementations of custom Job CRDs to use
Topology-Aware Scheduling with rank-based ordering.

@k8s-ci-robot k8s-ci-robot merged commit 9b7991f into kubernetes-sigs:main Dec 3, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

TAS: API to support rank-based ordering for custom CRDs
3 participants
@PBundyra @k8s-ci-robot @mimowo