Report Reserving queue metrics and stats. #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
size/XXL
trasc
force-pushed
the
cq-reserved-in-status
branch
from
f069acb to
460d966
Compare
trasc
force-pushed
the
cq-reserved-in-status
branch
from
460d966 to
4a0b8b3
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
tenzen-y
reviewed
Oct 20, 2023
|
/lgtm cancel |
k8s-ci-robot
removed
the
lgtm
|
otherwise lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9d29bc2b4356f1a2c0b170037a95056719cffdd2
|
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
PBundyra
pushed a commit
to PBundyra/kueue
that referenced
this pull request
Oct 26, 2023
* [api/cq] Add flavor reservation values. * [clusterqueue] Maintain different stats and metrics for Reserving and Admitted WL * [api/lq] Add flavor reservation values. * [localqueue] Maintain different stats for Reserving and Admitted WL * Review Remarks * Review Remarks * Review remarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Change the way localQueues and clusterQueues stats and mertics are reported to account for the difference between Reserving and Admitted workloads.
Which issue(s) this PR fixes:
Fixes #1195
Special notes for your reviewer:
Does this PR introduce a user-facing change?