Passing parameters to ProvisioningRequest from annotations #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
PBundyra
force-pushed
the
prov-req-annotations
branch
3 times, most recently
from
9072875 to
072ff25
Compare
gabesaba
reviewed
Mar 20, 2024
pkg/controller/jobs/kubeflow/jobs/pytorchjob/pytorchjob_controller_test.go
Outdated
Show resolved
Hide resolved
PBundyra
force-pushed
the
prov-req-annotations
branch
3 times, most recently
from
9b5ccef to
b2c28ea
Compare
|
/assign @yaroslava-serdiuk |
|
Please include integration tests for jobs and pods |
k8s-ci-robot
added
the
needs-rebase
PBundyra
force-pushed
the
prov-req-annotations
branch
from
b2c28ea to
313d18c
Compare
k8s-ci-robot
added
size/L
PBundyra
force-pushed
the
prov-req-annotations
branch
from
69e5a33 to
6cdc5b5
Compare
|
/retest |
1 similar comment
|
/retest |
|
I'll reverse changes regarding setup-envtest version when #1883 is merged |
PBundyra
force-pushed
the
prov-req-annotations
branch
from
83ad681 to
6cdc5b5
Compare
gabesaba
approved these changes
Mar 22, 2024
|
@gabesaba: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, gabesaba, PBundyra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
PBundyra
force-pushed
the
prov-req-annotations
branch
from
9032322 to
2b8b01c
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b4492ec0256b05671735ff07ea7339d1e273bc73
|
vsoch
pushed a commit
to researchapps/kueue
that referenced
this pull request
Apr 18, 2024
11 tasks
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
This implements changes introduced in #1788 and #1793
Which issue(s) this PR fixes:
Fixes #1788
Special notes for your reviewer:
I've done manual e2e testing
Does this PR introduce a user-facing change?