KEP-1432: AdmissionCheck per ResourceFlavor #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/assign @alculquicondor |
|
/assign @mwielgus |
gabesaba
reviewed
Apr 3, 2024
mimowo
reviewed
Apr 3, 2024
tenzen-y
reviewed
Apr 4, 2024
Co-authored-by: Yuki Iwai <[email protected]>
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b3079a157caab13ba1113f659a19be60f9473027
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, PBundyra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Apr 5, 2024
vsoch
pushed a commit
to researchapps/kueue
that referenced
this pull request
Apr 18, 2024
* KEP-1432: AdmissionCheck per ResourceFlavor * Simplify mechanism by discrading overriding AdmissionChecks, add a user story * Simplify mechanism to accept AdmissionChecks only at one level * Add integration test scenario * Add webhook validation * Update keps/1432-admission-check-per-resource-flavor/kep.yaml Co-authored-by: Yuki Iwai <[email protected]> * Introduce AdmissionCheckStrategy --------- Co-authored-by: Yuki Iwai <[email protected]>
11 tasks
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
* KEP-1432: AdmissionCheck per ResourceFlavor * Simplify mechanism by discrading overriding AdmissionChecks, add a user story * Simplify mechanism to accept AdmissionChecks only at one level * Add integration test scenario * Add webhook validation * Update keps/1432-admission-check-per-resource-flavor/kep.yaml Co-authored-by: Yuki Iwai <[email protected]> * Introduce AdmissionCheckStrategy --------- Co-authored-by: Yuki Iwai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Design for support for AdmissionChecks per ResourceFlavor
Which issue(s) this PR fixes:
Part of #1432
Special notes for your reviewer:
Does this PR introduce a user-facing change?