Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate MultiplePreemptions to Stable #3602

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Graduate MultiplePreemptions to Stable #3602

merged 1 commit into from
Nov 28, 2024

Conversation

gabesaba
Copy link
Contributor

@gabesaba gabesaba commented Nov 20, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Graduate MultiplePreemptions to stable, while cleaning up MultiplePreemptions=false branch. This simplifies the code base.

Which issue(s) this PR fixes:

Fixes #3601

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promote MultiplePreemptions feature gate to stable, and drop the legacy preemption logic.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 4438459
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/674864c170b67d0008876849

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 20, 2024
gabesaba
gabesaba commented Nov 20, 2024
View reviewed changes
pkg/cache/clusterqueue_test.go
@@ -94,309 +94,6 @@ func TestClusterQueueUpdateWithFlavors(t *testing.T) {
}
}

func TestFitInCohort(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try to salvage these tests, if you think they're worth keeping. Let me know what you think, reviewers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mimowo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, good question, the function is gone so we need to delete the tests for it, but maybe some of the low-level tests provide coverage for scenarios not handled by higher level tests.

Maybe you could run the following experiment: checkout main branch before this PR and generate coverage for TestFitInCohort, then checkout main and run coverage. check if there are any relevant branches which were covered before but now are missed.

@mimowo
Copy link
Contributor

mimowo commented Nov 20, 2024 •
edited
Loading

Thank you for the cleanup. It basically means MultiplePreemptions is graduated to stable, so we should reflect that in the kube_features. cc @tenzen-y ?

EDIT: what we typically do is we set the feature gate to stable, but keep it declared, so that users are not broken on upgrade if they have --feature-gate=MultiplePreemptions=true. Then we drop the declaration one or two releases later.

@mimowo
Copy link
Contributor

mimowo commented Nov 22, 2024

I think we shouldn't be cleaning up the logic while keeping the feature in Beta. I would be supportive of turning the PR into a feature which graduates the feature gate to stable.

@tenzen-y
Copy link
Member

Thank you for the cleanup. It basically means MultiplePreemptions is graduated to stable, so we should reflect that in the kube_features. cc @tenzen-y ?

EDIT: what we typically do is we set the feature gate to stable, but keep it declared, so that users are not broken on upgrade if they have --feature-gate=MultiplePreemptions=true. Then we drop the declaration one or two releases later.

Yes, we should keep the feature gate for a while like 2 minor versions.

@mimowo
Copy link
Contributor

mimowo commented Nov 25, 2024

@gabesaba please update it in kube_features, and just add a comment, "// remove in 1.12"

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2024
@gabesaba
Copy link
Contributor Author

@gabesaba please update it in kube_features, and just add a comment, "// remove in 1.12"

Updated. Is feature_gate.GA correct, or should I leave that as beta?

@gabesaba gabesaba changed the title Cleanup legacy preemption logic Graduate MultiplePreemptions to Stable Nov 28, 2024
mimowo
mimowo reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Seeing scheduling simplified is awesome!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 600e9ddb73f0e66cf9466003bfcfdccc1af27e2f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabesaba, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3e7d865 into kubernetes-sigs:main Nov 28, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Nov 28, 2024
@mimowo mimowo mentioned this pull request Nov 28, 2024
Closed
@mimowo
Copy link
Contributor

mimowo commented Nov 29, 2024

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 29, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 29, 2024

/release-note-edit

Promote MultiplePreemptions feature gate to stable, and drop the legacy preemption logic.

@gabesaba gabesaba deleted the cleanup_legacy_mp branch February 3, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@PBundyra PBundyra Awaiting requested review from PBundyra

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

Cleanup legacy preemption logic (where MultiplePreemptions=false)
4 participants
@gabesaba @mimowo @tenzen-y @k8s-ci-robot