TAS: validate that kubernetes.io/hostname can only be at the lowest level #3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/assign @PBundyra |
mbobrovskyi
force-pushed
the
feature/validate-kubernetes-io-hostname
branch
from
4cbac57 to
cb2ca1a
Compare
mimowo
reviewed
Dec 3, 2024
mimowo
reviewed
Dec 3, 2024
mbobrovskyi
force-pushed
the
feature/validate-kubernetes-io-hostname
branch
from
1d0d3b3 to
a7868d8
Compare
…evel Co-authored-by: Michał Woźniak <[email protected]>
mbobrovskyi
force-pushed
the
feature/validate-kubernetes-io-hostname
branch
from
a7868d8 to
d56c7cf
Compare
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 98855c6cbad2e3c0fe94a77ff6d24f6fd34c5b81
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Validate that kubernetes.io/hostname can only be at the lowest level in Topology.
Which issue(s) this PR fixes:
Fixes #3688
Special notes for your reviewer:
Does this PR introduce a user-facing change?