Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Multi-Kueue support to AppWrapper integration #3992

Merged
merged 15 commits into from
Feb 13, 2025
Merged

Add Multi-Kueue support to AppWrapper integration #3992

merged 15 commits into from
Feb 13, 2025

Conversation

dgrove-oss
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds multikueue adapter to appwrappers integration.

Which issue(s) this PR fixes:

Fixes #3989

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. labels Jan 17, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2025
@dgrove-oss dgrove-oss marked this pull request as draft January 17, 2025 02:27
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 889a773
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67aa26c5e67f0600081f1083
😎 Deploy Preview https://deploy-preview-3992--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mimowo
Copy link
Contributor

mimowo commented Jan 17, 2025

/cc @mszadkow for a review pass who is working recently on the integration for KubeRay

@k8s-ci-robot k8s-ci-robot requested a review from mszadkow January 17, 2025 10:05
@k8s-ci-robot
Copy link
Contributor

@mimowo: GitHub didn't allow me to request PR reviews from the following users: a, review, pass, who, on, the, KubeRay, is, working, recently, for.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @mszadkow for a review pass who is working recently on the integration for KubeRay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mszadkow
Copy link
Contributor

Remember to add to list of supported prebuiltWorkloads in validation.go

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2025
@dgrove-oss dgrove-oss changed the title Add Multi-Kueue support to AppWrapperi integration Add Multi-Kueue support to AppWrapper integration Jan 17, 2025
@dgrove-oss dgrove-oss marked this pull request as ready for review January 17, 2025 20:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tenzen-y January 17, 2025 20:58
@dgrove-oss
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
@dgrove-oss
Copy link
Contributor Author

dgrove-oss commented Jan 17, 2025 •
edited
Loading

I think to implement the proper managedBy defaulting for AppWrapper, I need to stop using the job framework's default webhook and switch back to a custom one (as in Job and JobSet) that include the managed by logic.

Is this the right approach, or should I look to generalize the base webhook so that it can incorporate optionally setting managedBy via an extension of GenericJob API? Perhaps by defining a JobWithManagedBy interface that had setters and getters

@mimowo
Copy link
Contributor

mimowo commented Jan 21, 2025

Maybe the suggestion to rename the prefix for the integration would actually make life easier also here. PTAL: #4024 (comment)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2025
@dgrove-oss
Copy link
Contributor Author

/retest

Due to #4113

@dgrove-oss
Copy link
Contributor Author

rebased to resolve appwrapper version bump (#4196)

@dgrove-oss dgrove-oss mentioned this pull request Feb 12, 2025
Open
mimowo
mimowo reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3efc91674cafb87522e72db3c4a7da2acb7a16db

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrove-oss, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit a23ffd9 into kubernetes-sigs:main Feb 13, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Feb 13, 2025
@dgrove-oss dgrove-oss deleted the awmk branch February 13, 2025 11:17
dgrove-oss added a commit to dgrove-oss/kueue that referenced this pull request Feb 14, 2025
@dgrove-oss
Add Multi-Kueue support to AppWrapper integration (kubernetes-sigs#3992)
6216ac7 
* appwrapper multi-kueue adapter

* AppWrapper implements JobWithManagedBy

* set queue name on appwrapper

* linter fix

* review comment: use waitForJobAdmitted in appwrapper test

* drop memory request for appwrapper test

* bump appwrapper version to 1.0.1

* review comment: appwrapper supports prebuilt workloads

* unit test defaulting of appwrapper by basewebhook

* Multikueue ==> MultiKueue

* bump appwrappers to 1.0.3

* fix expected completion message in appwrapper e2e test

* multikueueAdapter => multiKueueAdapter

* remove redundant webhook unit test

* review comment: simplify DeleteRemoteObject impl
@KPostOffice KPostOffice mentioned this pull request Feb 26, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@gabesaba gabesaba Awaiting requested review from gabesaba

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@mszadkow mszadkow Awaiting requested review from mszadkow

Assignees

@mszadkow mszadkow

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.

implement multi-kueue adapter for appwrapper integration
4 participants
@dgrove-oss @mimowo @k8s-ci-robot @mszadkow