-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent updating Job status on suspended jobs #4070
Prevent updating Job status on suspended jobs #4070
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/lgtm |
LGTM label has been added. Git tree hash: be10fe42be72268734257ad92602e9f9515b1842
|
/release-note-edit
@IrvingMg can you check / confirm if the Job CRDs updated in this PR (JobSet, KubeflowJobs, and MPIJob) can get status updated while they are suspended? |
Reproducing the original issue is difficult because it was found in a flaky test. However, I ran the end-to-end tests focusing on the updated jobs, and I can confirm that the condition is being hit. Here the filtered logs:
|
I see, so without this PR PyTorchJob status would be updated while suspended but apparently it does not violate any validation in PyTorch. I'm on a fence about cherry-picking this, but I would say this is still a minor bug we may want to cherry pick. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IrvingMg, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/king bug |
@mimowo: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mimowo: new pull request created: #4084 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Follow-up of #3685
Which issue(s) this PR fixes:
Fixes #3730
Special notes for your reviewer:
Does this PR introduce a user-facing change?