-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate error message for cohort and cluster queue #4473
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nasedil The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @nasedil. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/ok-to-test |
When parent cohort is empty it uses "parent" for cohort and "cohort" for cluster queue.
Error message in the test is not ignored because there was a misleading error message when using hierarchical cohorts. This test makes sure the message is different when validating cohort object.
When parent cohort is empty it uses "parent" for cohort and "cohort" for cluster queue.
What type of PR is this?
/kind bug
What this PR does / why we need it:
It fixes misleading error message in case of empty parent for hierarchical cohort and non-zero borrowing/lending limit.
Which issue(s) this PR fixes:
Fixes #4392
Special notes for your reviewer:
Does this PR introduce a user-facing change?