Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hard coded auth key leaking to new <action>? #468

Closed
rabbah opened this issue Feb 15, 2019 · 1 comment
Closed

hard coded auth key leaking to new <action>? #468

rabbah opened this issue Feb 15, 2019 · 1 comment

Comments

@rabbah
Copy link

rabbah commented Feb 15, 2019

I'm not sure why this is hardcoded - it's not really guaranteed to be true for local deployment and leads to surprising results.

https://github.com/IBM/kui/blob/0a411997976f46ff4be03ac27b49ebb27b42df4c/plugins/plugin-openwhisk/src/lib/cmds/auth.ts#L401

On new x, and then clicking deploy, the authentication header sent is this hard coded key even though auth add .... was done explicitly. The best I can figure so far is that maybe this key is somehow leaking threre.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@starpit @rabbah and others