Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composer is flaky in webpack #584

Closed
2 of 4 tasks
myan9 opened this issue Feb 27, 2019 · 2 comments
Closed
2 of 4 tasks

composer is flaky in webpack #584

myan9 opened this issue Feb 27, 2019 · 2 comments
Assignees
@myan9
Labels
kind/bug Categorizes issue or PR as related to a bug. plugin/apache-composer

Comments

@myan9
Copy link
Contributor

myan9 commented Feb 27, 2019 •
edited by starpit
Loading

  • preview @demos/if.js fails because of a readFile for webpack bug with imports

  • preview -c @demos/if.js fails for that bug, and a few other similar bugs

  • app deployment doesn't work in webpack
    Composer client (in openwhisk-composer libararay) is implemented to grab credentials from local wskprops, so in Webpack mode, we need to pass the api_host and api_key in options (in apache-composer/lib/controller/client) based on window.localStorage or process.env.__OW_API_KEY or process.env.__OW_API_HOST

  • clicking Deploy in compose foo.js fails because the composition persister uses tmp.file
@myan9 myan9 self-assigned this Feb 27, 2019
@myan9 myan9 added kind/bug Categorizes issue or PR as related to a bug. plugin/apache-composer labels Feb 27, 2019
@myan9 myan9 changed the title Composer client doesn't have wsk api_key and api_host in webpack mode app deployment doesn't work in webpack Feb 27, 2019
@myan9 myan9 changed the title app deployment doesn't work in webpack composer is flaky in webpack Mar 18, 2019
@myan9 myan9 mentioned this issue Mar 18, 2019
Closed
starpit added a commit to starpit/kui that referenced this issue Apr 16, 2019
@starpit
fix: apache-composer versus webpack fixes
5938c0b 
part of kubernetes-sigs#584
@starpit starpit mentioned this issue Apr 16, 2019
Merged
starpit added a commit that referenced this issue Apr 16, 2019
@starpit
fix: apache-composer versus webpack fixes
0a97daf 
part of #584
@starpit
Copy link
Contributor

starpit commented Apr 16, 2019

#1167 covers the first two

starpit added a commit to starpit/kui that referenced this issue Apr 17, 2019
@starpit
fix: apache-composer versus webpack fixes
21e55b5 
part of kubernetes-sigs#584
@starpit starpit mentioned this issue Dec 31, 2019
Open
4 tasks
@starpit
Copy link
Contributor

starpit commented Dec 31, 2019

moving to kui-shell/oui#56

@starpit starpit closed this as completed Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myan9 myan9

Labels
kind/bug Categorizes issue or PR as related to a bug. plugin/apache-composer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@starpit @myan9