Finish goplugins (release blocker)

[monopole]

Per the kep we need some more work goplugins started in #760

Release blockers:

• kustomize reads config (plugins specifically) from (a subdir of) $HOME/.config, and should honor XDG_CONFIG_HOME (see spec) as an override to this location.

• need flag --alpha_enable_goplugin_and_accept_panic_risk and associated behavior. The help for this flag should explain the problem.

Nice to haves:

• the existing three forms of KV generation (env, literals, files) should be expressible as pluginType:builtin.

• the existing edit fix command, which reads a kustomize file, updates it to new behavior, and writes it out again, should be modified to convert the three existing forms to builtin plugin form.

[sethpollack]

I can open some more PR's to add the rest of this.

[monopole]

Nice.

Now that you knocked off literals builtin, can you do env and files too?

And add add some tests like this : https://github.com/kubernetes-sigs/kustomize/blob/master/pkg/target/generatoroptions_test.go#L97
to cover them? In some new file (builtinplugins_test.go?)

Thanks!

[sethpollack]

Ok working on it, also working on kustomize edit fix

[monopole]

ah thanks - i'm out :)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[Liujingfang1]

The goplugin in secretGenerator is removed. Kustomize recommends to write generator plugin for that.