add builtin plugin for literals #883
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/assign @monopole |
| // Literals takes a list of literals. | ||
| // Each literal source should be a key and literal value, | ||
| // e.g. `somekey=somevalue` | ||
| // It will be similar to kubectl create configmap|secret --from-literal |
There was a problem hiding this comment.
No need for the reference to kubectl, as we're trying to steer people away from it's imperative commands.
| // parseLiteralSource parses the source key=val pair into its component pieces. | ||
| // This functionality is distinguished from strings.SplitN(source, "=", 2) since | ||
| // it returns an error in the case of empty keys, values, or a missing equals sign. | ||
| func parseLiteralSource(source string) (keyName, value string, err error) { |
There was a problem hiding this comment.
Until we decide to remove the non-plugin version of literals KV generation in k8sdeps/configmapandsecret/basefactory.go, we should use the same methods there and here. This will also be true for KV gen from env and files.
Could make the methods in configmapandsecret public, and use them here from there, or move them here and do the opposite, or slap them into a utils package...
There was a problem hiding this comment.
Ok, ill update.
|
@monopole updated. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole, sethpollack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
thanks! |
adds builtin plugins per #881