Update to Go 1.19

[KnVerey]

/cc @koba1t @annasong20

mod files updated via ./hack/for-each-module.sh 'sed -i "" "s/go 1.18/go 1.19/g" go.mod'

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KnVerey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[KnVerey]

The .0 addition should allow patch version updates but prevent CI from bumping itself up a minor version without us explicitly changing this file.

[koba1t]

It looks like the latest version is go1.19.3.
If you don't have any reason, Could you consider using the latest minor version?

[KnVerey]

The ^ should make that happen automatically, and also automatically pick up new patch-level versions as they are available. Currently it is picking up 1.19.2:

[koba1t]

Oh, Sorry.
I didn't know that. Thank you for showing the details!

[KnVerey]

pinning as suggested by Anna

[k8s-ci-robot]

@KnVerey: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[KnVerey]

stretch is rather old and has stopped receiving security updates. bullseye is the current stable distribution

[yuwenma]

Thanks for the comments. Good to know as well (like the ^ thing)

[KnVerey]

Fix for presubmit failure: kubernetes/test-infra#28043

[KnVerey]

/test kustomize-presubmit-master

[koba1t]

I think the below 2 files are using go1.18. So, Could you update that?

• kustomize/kyaml/fn/framework/command/command.go

  Line 124 in 62f0dab

  if err := os.WriteFile(filepath.Join(args[0], "Dockerfile"), []byte(`FROM golang:1.18-alpine as builder

• kustomize/kyaml/fn/framework/command/command_test.go

  Line 44 in 62f0dab

  expected := `FROM golang:1.18-alpine as builder

[yuwenma]

I think the below 2 files are using go1.18. So, Could you update that?

• kustomize/kyaml/fn/framework/command/command.go

  Line 124 in 62f0dab

  if err := os.WriteFile(filepath.Join(args[0], "Dockerfile"), []byte(`FROM golang:1.18-alpine as builder

• kustomize/kyaml/fn/framework/command/command_test.go

  Line 44 in 62f0dab

  expected := `FROM golang:1.18-alpine as builder

Oh, nice call. Besides, @KnVerey shall we consider using the distroless ("gcr.io/distroless/static") image to replace ln 132 FROM alpine:latest in AddGenerateDockerfile ? It is smaller and should be more secure. Not quite relevant to this PR though, defer to you.

[annasong20]

I compared this PR with @koba1t 's go1.18 PR #4699. That PR touches the following Dockerfiles:

• functions/examples/template-heredoc-cockroachdb/image/Dockerfile
• functions/examples/validator-kubeval/image/Dockerfile
• functions/examples/validator-resource-requests/image/Dockerfile

that this PR doesn't. Do we want to change golang:1.18-stretch to golang:1.19-bullseye in these files?

Also, I'm assuming, since all checks passed, that we didn't change any go.sum files here because the go version upgrade didn't result in any package dependency upgrades?

My understanding of the touched files is rather basic, so feel free to ignore any uninformed comments. Really appreciate this PR!

[KnVerey]

Thanks for the sanity checks! I had indeed missed a bunch of places.

shall we consider using the distroless ("gcr.io/distroless/static") image to replace ln 132 FROM alpine:latest in AddGenerateDockerfile ? It is smaller and should be more secure. Not quite relevant to this PR though, defer to you.

I'm not opposed to reconsidering the images we use in various places (often in examples where distroless would be just fine, or where pinning a specific version of Go really isn't necessary), but it is out of scope for this PR.

[annasong20]

/lgtm