-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow empty port list for ANP peers. #250
Conversation
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@danwinship don't you bump the versions for these changes? v1alpha2? |
/approve
pfft. YOLO! Yeah, it's technically an API break, but it's alpha. I guess people who are shipping this alpha API to customers (meaningful glance) will have to decide whether or not to ship the break. (leaving un-lgtm'ed to give others a chance to comment) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, npinaeva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Signed-off-by: Nadia Pinaeva <[email protected]>
ab54ae3
to
a14d924
Compare
had to rebase to fix CI |
I see, ok, let me know when you have planned a release to update the network policies, |
we may want to do a release before kubecon, and then freeze there, otherwise we loose credibility too |
we can break between alpha minors |
/lgtm |
Based on discussion #247
Zero-length port list is different from the nil port list, and it means do not match any port, which makes that peer not matching any traffic.
This is confusing and is more of an accident than an intention.
Closes #247