test git actions

kubernetes-sigs · Mar 10, 2022 · cc4c26b · cc4c26b
1 parent 424fa5a
commit cc4c26b
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 44 deletions.
diff --git a/.github/workflows/helm-chart-lint.yml b/.github/workflows/helm-chart-lint.yml
diff --git a/.github/workflows/helm-chart-release.yml b/.github/workflows/helm-chart-release.yml
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -52,7 +52,6 @@ jobs:
         if: github.event_name != 'pull_request'
         uses: docker/login-action@v1
         with:
-          registry: quay.io
           username: ${{ secrets.REGISTRY_USERNAME }}
           password: ${{ secrets.REGISTRY_TOKEN }}
       -

diff --git a/cmd/nfs-subdir-external-provisioner/provisioner.go b/cmd/nfs-subdir-external-provisioner/provisioner.go
@@ -141,7 +141,9 @@ func (p *nfsProvisioner) Provision(ctx context.Context, options controller.Provi
 
 func (p *nfsProvisioner) Delete(ctx context.Context, volume *v1.PersistentVolume) error {
 	path := volume.Spec.PersistentVolumeSource.NFS.Path
+	//basePath still needed later
 	basePath := filepath.Base(path)
+	//replace NFS Server Path with mountPath in Container
 	oldPath := strings.Replace(path, p.path, mountPath, 1)
 
 	if _, err := os.Stat(oldPath); os.IsNotExist(err) {
@@ -162,6 +164,7 @@ func (p *nfsProvisioner) Delete(ctx context.Context, volume *v1.PersistentVolume
 
 	case "delete":
 		return os.RemoveAll(oldPath)
+		//TODO: Remove empty folders
 
 	case "retain":
 		return nil