remove BUILD_PLATFORM variable setting from the makefile #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as the tuple of BUILD_PLATFORM changed for release-tools for multi-arch builds, we need to change either correct the variable in the repo or delegate that setting to csi-release-tool setting Signed-off-by: Humble Chirammal <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign @pohly |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: humblec, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the tuple of BUILD_PLATFORM changed for csi-release-tools for
multi-arch builds, we need to either correct the variable
in the repo or delegate that setting to csi-release-tool setting.
Ref # kubernetes-csi/csi-release-tools#181
This is causing the test to fail as seen here:
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/canary-nfs-subdir-external-provisioner-push-images/1521591446950383616
Fix # kubernetes/kubernetes#109910
Signed-off-by: Humble Chirammal [email protected]