Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Test if buildx is enabled at Prow #582

Closed

Conversation

ArangoGutierrez
Copy link
Contributor

Fixes #426

THIS IS A WIP PR, TO TEST PROW FUNCTIONALITY TOWARDS DOCKER BUILDX

DO NOT LGTM OR MERGE

Signed-off-by: Carlos Eduardo Arango Gutierrez [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArangoGutierrez
To complete the pull request process, please assign marquiz after the PR has been reviewed.
You can assign the PR to them by writing /assign @marquiz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from zvonkok August 23, 2021 12:23
@ArangoGutierrez
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2021
@ArangoGutierrez ArangoGutierrez changed the title Test if buildx is enabled at Prow WIP: Test if buildx is enabled at Prow Aug 23, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2021
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Copy link
Contributor Author

/test pull-node-feature-discovery-build-image

@ArangoGutierrez
Copy link
Contributor Author

@marquiz how do you wanna move forward with this initiative?

@marquiz
Copy link
Contributor

marquiz commented Sep 21, 2021

@marquiz how do you wanna move forward with this initiative?

Does this work? 😉
/retest

When/if image building passes you can start working on the makefile. We should probably have ARCH or smth as a Makefile variable. And prolly only use buildx if ARCH has been set ,i.e. do a native build by default.

@ArangoGutierrez
Copy link
Contributor Author

let's add this to V0.11 milestone

@ArangoGutierrez
Copy link
Contributor Author

in lieu of #698
/close

@k8s-ci-robot
Copy link
Contributor

@ArangoGutierrez: Closed this PR.

In response to this:

in lieu of #698
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for arm64, armV7, armV8
3 participants