feat(values): add kubernetesRootDir

[eyenx]

What this PR does / why we need it:

Adds providersDir to the linux and windows values to be able to configure the hostPath mountpoint of the Daemonset.

Not all Kubernetes Distributions set their kubernetesRootDir under /etc/kubernetes (example: Nutanix Karbon).

Special notes for your reviewer:

First PR in this repo.

[k8s-ci-robot]

Welcome @eyenx!

It looks like this is your first PR to kubernetes-sigs/secrets-store-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/secrets-store-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @eyenx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eyenx]

/assign @ritazh

[ritazh]

Thanks for the PR @eyenx!
Can you please make these changes in the yamls in manifest_staging/charts where we host the staging charts? All the chart changes will then be promoted into the released charts folder with the next release. Thanks!

[aramase]

Thank you for the PR @eyenx.

1. As @ritazh pointed out all the changes are required to be made in manifest_staging/charts folder.
2. I think it would be better to have the whole providers-dir configurable instead of just the kubernetes dir. So we can add providersDir and default is /etc/kubernetes/secrets-store-csi-providers for Linux and C:\k\secrets-store-csi-providers for Windows. I would love to hear what others think about this.
3. Please also add the new configurable values to the configuration table

[eyenx]

@ritazh @aramase as requested, made my changes in the manifest_staging folder and switched to using providersDir instead of kubernetesRootDir and added the docs in the README.md

[aramase]

@eyenx Could you also update the values here:

• https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/master/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml#L55
• https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/master/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver-windows.yaml#L53

[eyenx]

Those lines aren't really relevant for this change, as the mountPath is the path which is valid inside the pod: L103 And that can stay the same in my opinion.

[eyenx]

a.e. the registration Volume's mountPath is also hardcoded: L38

[aramase]

/ok-to-test

[aramase]

#418 already opened for pull-secrets-store-csi-driver-e2e-gcp failures.

[tam7t]

I think this needs to become a requirement for supported providers actually. Currently the GCP provider install has hardcoded providervol set to /etc/kubernetes/secrets-store-csi-providers.

And I think the azure plugin would need to be updated to accept this configuration here: https://github.com/Azure/secrets-store-csi-driver-provider-azure/blob/50aaa7b66843a2d58bc4895dacc01000d5b541d3/manifest_staging/charts/csi-secrets-store-provider-azure/templates/provider-azure-installer.yaml#L60-L63

[aramase]

I think this needs to become a requirement for supported providers actually. Currently the GCP provider install has hardcoded providervol set to /etc/kubernetes/secrets-store-csi-providers.

It's the same for all providers. But I think we should add a note before next release that if this value is changed, then also make sure to update the volume in the provider manifests. WDYT?

I think with helm if the driver is packaged as part of provider, then it'll be handled.

[aramase]

/test pull-secrets-store-csi-driver-e2e-gcp

[tam7t]

@aramase ah that sounds good to me, realizing now that it is just a deploy configuration yaml parameter and not something that provider code implementations really need to be aware of.

[aramase]

/lgtm

[ritazh]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eyenx, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ritazh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment