Use latest go in UBI go-toolset #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
==========================================
- Coverage 45.50% 41.38% -4.12%
==========================================
Files 79 109 +30
Lines 7782 18240 +10458
==========================================
+ Hits 3541 7549 +4008
- Misses 4099 10192 +6093
- Partials 142 499 +357 |
saschagrunert
force-pushed
the
go-1.23
branch
from
ac17759 to
6a5eada
Compare
k8s-ci-robot
added
size/L
We won't see go 1.23 there soon so we now stick to download the latest golang version manually to be able to upgrade all our dependencies. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
go-1.23
branch
from
6a5eada to
2b98a0c
Compare
ccojocar
approved these changes
Dec 5, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We won't see go 1.23 there soon so we now stick to download the latest golang version manually to be able to upgrade all our dependencies.
Which issue(s) this PR fixes:
None
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?