Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite only some settings in the security context when apparmor is enabled #2612

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Overwrite only some settings in the security context when apparmor is enabled #2612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions internal/pkg/manager/spod/spod_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,15 +576,14 @@ func (r *ReconcileSPOd) getConfiguredSPOd(
if cfg.Spec.EnableAppArmor {
falsely, truly := false, true
var userRoot int64
// a more privileged mode is required when apparmor is enabled
// A more privileged mode is required when apparmor is enabled.
// TODO: review security model and provide a dynamic approach that can be case specific
templateSpec.Containers[bindata.ContainerIDDaemon].SecurityContext = &corev1.SecurityContext{
AllowPrivilegeEscalation: &truly,
Privileged: &truly,
ReadOnlyRootFilesystem: &falsely,
RunAsUser: &userRoot,
RunAsGroup: &userRoot,
}
sc := templateSpec.Containers[bindata.ContainerIDDaemon].SecurityContext
sc.AllowPrivilegeEscalation = &truly
sc.Privileged = &truly
sc.ReadOnlyRootFilesystem = &falsely
sc.RunAsUser = &userRoot
sc.RunAsGroup = &userRoot

templateSpec.Containers[bindata.ContainerIDDaemon].Args = append(
templateSpec.Containers[bindata.ContainerIDDaemon].Args,
Expand Down
Loading