-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer need HostProcess specific build since containerd pr merged #163
No longer need HostProcess specific build since containerd pr merged #163
Conversation
/cc @marosset |
Can we just disable it for now? |
I lean toward removing it to avoid confusion several months later when we revisit if the requirement for dev branches is required. This was really to fill a gap while we landed it across all of the moving parts. The less custom stuff we have the better IMO. |
Can we keep this around (but disabled) until the KEP to move HostProcess containers to beta gets reviewed (Sept 9 is the enhancement freeze)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I spoke w/ @jsturtevant offline and we decided we'll just bring back the workflow if needed to keep the repo tidy.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for PR:
Removes the HostProcess build as containerd/containerd#5131 has merged.
Issue Fixed:
Issue #
Requirements
Notes: