Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise author in license #176

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Revise author in license #176

merged 1 commit into from
Oct 14, 2021

Conversation

hxietkg
Copy link
Contributor

@hxietkg hxietkg commented Oct 14, 2021

Change author to 'The Kubnernetes Authoers' in license header

Reason for PR:

Wrong author is used in burrito files

Issue Fixed:

Issue #175

test:
docker build/run

Requirements

  • Sqaush commits
  • Documentation
  • Tests

Notes:

@hxietkg
Revise author in license
bedc1cb 
Change author to 'The Kubnernetes Authoers' in license header
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hxietkg
To complete the pull request process, please assign jayunit100 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jayunit100 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 14, 2021
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 14, 2021
@jayunit100
Copy link
Contributor

@perithompson assuming this is ok with you :) :)

@jayunit100 jayunit100 merged commit d3cce15 into kubernetes-sigs:master Oct 14, 2021
@perithompson
Copy link
Contributor

bit late but yes looks good :)

@hxietkg hxietkg deleted the hxie-revise-author branch October 14, 2021 15:22
@jayunit100
Copy link
Contributor

image
thanks peri, fyi for historical purposes, peri on board with this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayunit100 jayunit100 Awaiting requested review from jayunit100

@marosset marosset Awaiting requested review from marosset

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hxietkg @k8s-ci-robot @jayunit100 @perithompson