-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hostprocess-calico): Prevent removing WSL network #188
Conversation
Are you running this on Windows 10/11? |
Yes, tried out a setup where the control plane is running in WSL and the Windows 11 host joins as a Worker. Thought that might be a good development setup somewhere in the future. Existing solutions like Rancher Desktop don't support adding Windows nodes and especially when you develop apps for Windows Containers you often need some other components running on Linux. |
this is a great idea! have you gotten it to work? I don't see any harm in updating these manifests as it is a no op if it isn't there and opens up the door for this scenario. |
Everything works apart from networking. Pods can only curl other pods on the same node but not on other nodes. Calico initializes sucessfully, pods get an IP assigned from overlay network and Felix successfully seems to create routes. Logs don't show any errors. With having too less knowledge about routing internals and not knowing who could help I gave up for now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lippertmarkus, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for PR:
This prevents the calico node startup script to delete the WSL HnsNetwork which breaks WSL when running on Windows 11.
Issue Fixed:
Requirements
Notes: