Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hostprocess-calico): Prevent removing WSL network #188

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

lippertmarkus
Copy link
Contributor

@lippertmarkus lippertmarkus commented Nov 28, 2021

Reason for PR:
This prevents the calico node startup script to delete the WSL HnsNetwork which breaks WSL when running on Windows 11.

Issue Fixed:

Requirements

  • Sqaush commits
  • [-] Documentation
  • [-] Tests

Notes:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 28, 2021
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 28, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2021
@jsturtevant
Copy link
Contributor

Are you running this on Windows 10/11?

@lippertmarkus
Copy link
Contributor Author

Yes, tried out a setup where the control plane is running in WSL and the Windows 11 host joins as a Worker. Thought that might be a good development setup somewhere in the future. Existing solutions like Rancher Desktop don't support adding Windows nodes and especially when you develop apps for Windows Containers you often need some other components running on Linux.

@jsturtevant
Copy link
Contributor

Yes, tried out a setup where the control plane is running in WSL and the Windows 11 host joins as a Worker. Thought that might be a good development setup somewhere in the future.

this is a great idea! have you gotten it to work?

I don't see any harm in updating these manifests as it is a no op if it isn't there and opens up the door for this scenario.

@lippertmarkus
Copy link
Contributor Author

Everything works apart from networking. Pods can only curl other pods on the same node but not on other nodes. Calico initializes sucessfully, pods get an IP assigned from overlay network and Felix successfully seems to create routes. Logs don't show any errors. With having too less knowledge about routing internals and not knowing who could help I gave up for now...

Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lippertmarkus, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 36bf671 into kubernetes-sigs:master Dec 2, 2021
@lippertmarkus lippertmarkus deleted the patch-1 branch December 3, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants