Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows 20h2 and 2022 #205

Merged
merged 3 commits into from
Feb 18, 2022
Merged

Add support for Windows 20h2 and 2022 #205

merged 3 commits into from
Feb 18, 2022

Conversation

Mik4sa
Copy link
Contributor

@Mik4sa Mik4sa commented Jan 30, 2022

Reason for PR:
I couldn't get flannel to work on my Windows Server 2022 (virtual machine). I noticed that the images were missing support for 20H2 and 2022. So here it's.

Notice: I'm not too sure if the version change of the pause image to 3.6 is fine, but it was needed for Windows Server 2022, since version 1.4.1 of the pause image isn't supported on 2022.

I pushed the updated container images for kube-proxy and flannel in my repositories:
https://hub.docker.com/r/mik4sa/kube-proxy
https://hub.docker.com/r/mik4sa/flannel

PS: I'm fairly new to the whole kubernetes world.

@k8s-ci-robot
Copy link
Contributor

Welcome @Mik4sa!

It looks like this is your first PR to kubernetes-sigs/sig-windows-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-windows-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 30, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2022
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 30, 2022
@Mik4sa Mik4sa marked this pull request as draft January 30, 2022 10:10
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 30, 2022

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 30, 2022
@Mik4sa Mik4sa marked this pull request as ready for review January 30, 2022 12:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2022
@Mik4sa Mik4sa removed their assignment Feb 11, 2022
@Mik4sa
Copy link
Contributor Author

Mik4sa commented Feb 11, 2022

/assign @ddebroy @marosset

@marosset
Copy link
Contributor

/lgtm
I'll approve after the CI jobs pass.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2022
@Mik4sa
Copy link
Contributor Author

Mik4sa commented Feb 18, 2022

@marosset Any news? As far as I can see the CI jobs completed successfully?
Correct me if I‘m wrong

@marosset
Copy link
Contributor

@marosset Any news? As far as I can see the CI jobs completed successfully? Correct me if I‘m wrong

You are correct.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, Mik4sa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1ab39f1 into kubernetes-sigs:master Feb 18, 2022
@Mik4sa Mik4sa deleted the support-20h2-2022 branch February 18, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants