Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH action to copy images from sigwindowstools/ to ghcr.io #213

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Apr 19, 2022

Reason for PR:

This PR adds a github actions to sync container images from sigwindowstools/* to ghcr.io/kubernetes-sigs/sig-windows/*

This workflow will be used to backfill images already published to sigwindowstools.

Issue Fixed:
Related to kubernetes-sigs/cluster-api-provider-azure#2230

Requirements

  • Sqaush commits
  • Documentation
  • Tests

Notes:
This workflow has been validated in my fork of the repo
https://github.com/marosset/sig-windows-tools/actions/workflows/copy-image.yml
https://github.com/marosset/sig-windows-tools/pkgs/container/sig-windows%2Fkube-proxy

/sig windows
/assign @jsturtevant

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 26, 2022
@marosset
Copy link
Contributor Author

Updated the PR to use regsync to sync multiple images at once.

I validated this in my GH fork

@jsturtevant
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit aa2bbac into kubernetes-sigs:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants