-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update OWNERS file #69
base: main
Are you sure you want to change the base?
Conversation
/lgtm |
9719be9
to
3028c72
Compare
OWNERS_ALIASES
Outdated
@@ -0,0 +1,28 @@ | |||
# See the OWNERS docs at https://go.k8s.io/owners | |||
|
|||
aliases: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is sort of needlessly opaque (and prevents emeritus-ing) if we're just going to use it in OWNERS/ anyhow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can drop and we use just Owners
OWNERS_ALIASES
Outdated
- kaslin | ||
- palnabarun | ||
|
||
sig-k8s-infra-leads: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO: I pinged the current set of leads to invite them to help because we need people from somewhere (and same for contribex), but I don't know that this is strictly related to those roles long term if we gain healthy subproject owners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to hold this PR then, or approve it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My personal suggestion is that we inline the approvers in OWNERS as just the owners of this repo, but I don't consider it a hard blocker. Nobody currently on the PR can actually approve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did an update, PTAL
Signed-off-by: cpanato <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cpanato The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gently ping to we close this and we can move forward @jberkus @BenTheElder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Fix: #67
let me know if that is correct or if need to add/remove
cc @BenTheElder @jberkus