Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update OWNERS file #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 20, 2024

Fix: #67

let me know if that is correct or if need to add/remove
cc @BenTheElder @jberkus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Dec 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 20, 2024
@MadhavJivrajani
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
OWNERS_ALIASES Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2024
@cpanato cpanato requested a review from jberkus December 25, 2024 15:25
OWNERS_ALIASES Outdated
@@ -0,0 +1,28 @@
# See the OWNERS docs at https://go.k8s.io/owners

aliases:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is sort of needlessly opaque (and prevents emeritus-ing) if we're just going to use it in OWNERS/ anyhow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can drop and we use just Owners

OWNERS_ALIASES Outdated
- kaslin
- palnabarun

sig-k8s-infra-leads:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO: I pinged the current set of leads to invite them to help because we need people from somewhere (and same for contribex), but I don't know that this is strictly related to those roles long term if we gain healthy subproject owners.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to hold this PR then, or approve it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My personal suggestion is that we inline the approvers in OWNERS as just the owners of this repo, but I don't consider it a hard blocker. Nobody currently on the PR can actually approve it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did an update, PTAL

Signed-off-by: cpanato <[email protected]>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpanato
Once this PR has been reviewed and has the lgtm label, please assign katharine for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2025
@cpanato
Copy link
Member Author

cpanato commented Jan 20, 2025

gently ping to we close this and we can move forward @jberkus @BenTheElder
we can adjust a fine grain maybe in a follow up

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2025
@BenTheElder
Copy link
Member

We will need an existing approver to get this in:
/assign @jeefy @nikhita

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update OWNERS
8 participants