Merge pull request #242 from kmala/master

deep copy slice object during append
kubernetes-sigs · Jul 10, 2023 · 7785c50 · 7785c50
2 parents a345f52 + 69bc7e7
commit 7785c50
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/merge/conflict.go b/merge/conflict.go
@@ -112,7 +112,7 @@ func ConflictsFromManagers(sets fieldpath.ManagedFields) Conflicts {
 		set.Set().Iterate(func(p fieldpath.Path) {
 			conflicts = append(conflicts, Conflict{
 				Manager: manager,
-				Path:    p,
+				Path:    p.Copy(),
 			})
 		})
 	}

diff --git a/merge/conflict_test.go b/merge/conflict_test.go
@@ -92,3 +92,22 @@ func TestToSet(t *testing.T) {
 		t.Fatalf("expected\n%v\n, but got\n%v\n", expected, actual)
 	}
 }
+
+func TestConflictsFromManagers(t *testing.T) {
+	got := merge.ConflictsFromManagers(fieldpath.ManagedFields{
+		"Bob": fieldpath.NewVersionedSet(
+			_NS(
+				_P("obj", "template", "obj", "list", _KBF("name", "a"), "id"),
+				_P("obj", "template", "obj", "list", _KBF("name", "a"), "key"),
+			),
+			"v1",
+			false,
+		),
+	})
+	wanted := `conflicts with "Bob":
+- .obj.template.obj.list[name="a"].id
+- .obj.template.obj.list[name="a"].key`
+	if got.Error() != wanted {
+		t.Errorf("Got %v, wanted %v", got.Error(), wanted)
+	}
+}