Metadata Syncer for vsphere CSI Driver

[RaunakShah]

What this PR does / why we need it:
The goal of Metadata Syncer is to push vSphere container volume metadata (PV labels, PVC labels, the name of the Pod consuming container volume) from Kubernetes Cluster to vSphere.
This metadata will also be presented to VC or Storage Admin on vSphere UI.
For this design we have taken into consideration, that CSI is container orchestrator agnostic, so we cannot directly use Kubernetes objects in the CSI controller/node plugin code. We will be running separate container in the controller plugin pod, to update metadata for CNS Volumes.
We call this container as "Metadata Syncer".

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
Integration, unit and e2e tests for this container will be added in the following PRs. This PR only adds the informer code to perform these updates.

Release note:

Metadata Syncer for vSphere CSI Driver

[k8s-ci-robot]

Welcome @RaunakShah!

It looks like this is your first PR to kubernetes-sigs/vsphere-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/vsphere-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @RaunakShah. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[RaunakShah]

Signed the CLA

[codenrhoden]

/ok-to-test

[RaunakShah]

/assign @codenrhoden
/assign @frapposelli
/assign @dvonthenen
/assign @andrewsykim

[davidvonthenen]

Other than the small nit that was pointed out, code-wise this looks pretty good! Awesome job! I can't really comment on whether or not this is doing what is intended... but will rely on others to make that determination.

/lgtm

[codenrhoden]

LGTM

Just the nit from divyen to address and I'm curious about the k/k dependency...

[codenrhoden]

I'll file an issue to follow-up on this later, but this is a really old version of k/k to pull in. It's outside of the "n-2" support policy. The vSphere CPI recently updated it's dependency to 1.15.0, and I know it was a ton of work to do so. At some point the same thing should happen here.

[codenrhoden]

And actually, as I've looked at the new *.go files, the only direct imports of k8s.io/* packages are of klog, client-go, and api. So I'm wondering why kubernetes is being added as a direct dependency here at all... 🤔

[RaunakShah]

Good catch! I had some tests as part of this PR earlier and overlooked removing it when i removed the tests. Since you've pointed it out, maybe we'll look at that internally and try to resolve any issues ASAP. Thanks!

[RaunakShah]

/retest

[RaunakShah]

Thanks @divyenpatel @dvonthenen @codenrhoden for the swift reviews! Ive rebased all commits into one based on your comments

[codenrhoden]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden, RaunakShah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [codenrhoden]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment