Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable e2e test #10

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Enable e2e test #10

merged 1 commit into from
Oct 28, 2021

Conversation

qiujian16
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2021
@qiujian16 qiujian16 changed the title Enable e2e test [WIP] Enable e2e test Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2021
@qiujian16 qiujian16 force-pushed the add-e2e branch 16 times, most recently from fe13361 to bcce9d8 Compare September 15, 2021 10:18
@qiujian16 qiujian16 force-pushed the add-e2e branch 2 times, most recently from 1189636 to 1664c61 Compare September 17, 2021 06:42
mikeshng
mikeshng suggested changes Sep 20, 2021
View reviewed changes
Copy link
Member

@mikeshng mikeshng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit comment.

@qiujian16 qiujian16 force-pushed the add-e2e branch 2 times, most recently from 9c8cf72 to 6cc8883 Compare September 23, 2021 10:09
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 23, 2021
@qiujian16 qiujian16 force-pushed the add-e2e branch 7 times, most recently from 15268f4 to 46b5d9a Compare September 24, 2021 08:06
@qiujian16
Copy link
Contributor Author

/assign @RainbowMango

@qiujian16 qiujian16 changed the title [WIP] Enable e2e test Enable e2e test Sep 24, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2021
@RainbowMango
Copy link
Member

Congratulation! You made it!
I'll take a look ASAP. Thanks.

RainbowMango
RainbowMango reviewed Oct 9, 2021
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiujian16
Generally LGTM only some questions.

.github/workflows/ci.yml
- name: verify
run: hack/verify-all.sh -v
env:
GOPATH: '/home/runner/work/work-api/work-api/go'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question, why do we require GOPATH? IMO, it can be run anywhere as we enabled Go module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems *-gen requires GOPATH, otherwise it cannot found the correct path to generate code...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird. It works for me with Go module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the gopath is exported here https://github.com/karmada-io/karmada/blob/master/hack/update-codegen.sh#L13?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure :(
But that's not big deal. Let's move forward.

@RainbowMango
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9cd9e70 into kubernetes-sigs:master Oct 28, 2021
@qiujian16 qiujian16 deleted the add-e2e branch October 28, 2021 10:19
@mikeshng mikeshng mentioned this pull request Dec 7, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango left review comments

@mikeshng mikeshng mikeshng requested changes

@JeremyOT JeremyOT Awaiting requested review from JeremyOT

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qiujian16 @RainbowMango @k8s-ci-robot @mikeshng