refactor: use a limiting interface in actuator in place of `NodeGroup…

…ConfigProcessor` interface

- to limit the functions that can be used
- since we need it only for `GetIgnoreDaemonSetsUtilization`
Signed-off-by: vadasambar <[email protected]>

cluster-autoscaler/core/scaledown/actuation/actuator.go

@@ -34,7 +34,6 @@ import (
 	"k8s.io/autoscaler/cluster-autoscaler/core/utils"
 	"k8s.io/autoscaler/cluster-autoscaler/metrics"
 	"k8s.io/autoscaler/cluster-autoscaler/processors"
-	"k8s.io/autoscaler/cluster-autoscaler/processors/nodegroupconfig"
 	"k8s.io/autoscaler/cluster-autoscaler/simulator"
 	"k8s.io/autoscaler/cluster-autoscaler/simulator/clustersnapshot"
 	"k8s.io/autoscaler/cluster-autoscaler/simulator/utilization"
@@ -53,7 +52,14 @@ type Actuator struct {
 	nodeDeletionBatcher *NodeDeletionBatcher
 	evictor             Evictor
 	deleteOptions       simulator.NodeDeleteOptions
-	nodeConfigProcessor nodegroupconfig.NodeGroupConfigProcessor
+	configGetter        actuatorNodeGroupConfigGetter
+}
+
+// actuatorNodeGroupConfigGetter is an interface to limit the functions that can be used
+// from NodeGroupConfigProcessor interface
+type actuatorNodeGroupConfigGetter interface {
+	// GetIgnoreDaemonSetsUtilization returns IgnoreDaemonSetsUtilization value that should be used for a given NodeGroup.
+	GetIgnoreDaemonSetsUtilization(context *context.AutoscalingContext, nodeGroup cloudprovider.NodeGroup) (bool, error)
 }
 
 // NewActuator returns a new instance of Actuator.
@@ -66,7 +72,7 @@ func NewActuator(ctx *context.AutoscalingContext, csr *clusterstate.ClusterState
 		nodeDeletionBatcher: nbd,
 		evictor:             NewDefaultEvictor(deleteOptions, ndt),
 		deleteOptions:       deleteOptions,
-		nodeConfigProcessor: processors.NodeGroupConfigProcessor,
+		configGetter:        processors.NodeGroupConfigProcessor,
 	}
 }
 
@@ -311,7 +317,7 @@ func (a *Actuator) scaleDownNodeToReport(node *apiv1.Node, drain bool) (*status.
 		return nil, err
 	}
 
-	ignoreDaemonSetsUtilization, err := a.nodeConfigProcessor.GetIgnoreDaemonSetsUtilization(a.ctx, nodeGroup)
+	ignoreDaemonSetsUtilization, err := a.configGetter.GetIgnoreDaemonSetsUtilization(a.ctx, nodeGroup)
 	if err != nil {
 		return nil, err
 	}