Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented TemplateNodeInfo function #3671

Merged
merged 4 commits into from
Nov 6, 2020
Merged

implemented TemplateNodeInfo function #3671

merged 4 commits into from
Nov 6, 2020

Conversation

wangshiqi308
Copy link
Contributor

@wangshiqi308 wangshiqi308 commented Nov 5, 2020 •
edited
Loading

Implemented TemplateNodeInfo function. TemplateNodeInfo returns a schedulerframework.NodeInfo structure of an empty
(as if just started) node. This will be used in scale-up simulations to predict what would a new node look like if a node group was expanded. The returned NodeInfo is expected to have a fully populated Node object, with all of the labels, capacity and allocatable information as well as all pods that are started on the node by default, using manifest (most likely only kube-proxy).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 5, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @wangshiqi308!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2020
@wangshiqi308
Copy link
Contributor Author

wangshiqi308 commented Nov 5, 2020 •
edited
Loading

/assign @ysy2020 @RainbowMango

@ysy2020
Copy link
Contributor

ysy2020 commented Nov 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020
@ysy2020
Copy link
Contributor

ysy2020 commented Nov 5, 2020

/assign @RainbowMango

RainbowMango
RainbowMango reviewed Nov 6, 2020
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, otherwise LGTM.
Thanks.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2020
@RainbowMango
Copy link
Member

/lgtm
/approve

Congrats! For your first PR! Good job!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, wangshiqi308

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2020
@RainbowMango
Copy link
Member

Just a reminder, it's better to squash your commits when you fix comments. :)

@k8s-ci-robot k8s-ci-robot merged commit a414125 into kubernetes:master Nov 6, 2020
@wangshiqi308 wangshiqi308 deleted the pr_implements_templatenodeinfo branch November 6, 2020 18:41
@wangshiqi308 wangshiqi308 mentioned this pull request Nov 23, 2020
Closed
6 tasks
@bpineau bpineau mentioned this pull request Jan 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@RainbowMango RainbowMango

@ysy2020 ysy2020

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangshiqi308 @k8s-ci-robot @ysy2020 @RainbowMango