Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3714: Add build support for ARM64 #3762

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 14, 2020

Cherry pick of #3714 on cluster-autoscaler-release-1.19.

#3714: Add build support for ARM64

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 14, 2020
@hakman hakman force-pushed the automated-cherry-pick-of-#3714-upstream-cluster-autoscaler-release-1.19 branch from 6adb491 to 6a027dc Compare December 14, 2020 15:42
@hakman
Copy link
Member Author

hakman commented Dec 15, 2020

/cc @gjtempleton

@gjtempleton
Copy link
Member

/lgtm

@MaciekPytel this is related to the discussion during office hours about Kops wanting to cut an ARM supporting 1.19 release.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2020
@hakman
Copy link
Member Author

hakman commented Dec 15, 2020

Thanks @gjtempleton & @MaciekPytel.
#3768 may need to be cherrypicked also if accepted.

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit e733dfa into kubernetes:cluster-autoscaler-release-1.19 Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants