Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[manila-csi-plugin] Bump sidecar versions for v1.22 release #1618

Merged
merged 4 commits into from
Aug 15, 2021
Merged

[manila-csi-plugin] Bump sidecar versions for v1.22 release #1618

merged 4 commits into from
Aug 15, 2021

Conversation

gman0
Copy link
Member

@gman0 gman0 commented Aug 10, 2021

What this PR does / why we need it:

This PR updates sidecars for v1.22:

  • csi-node-driver-registrar: v1.3.0 -> v2.2.0
  • csi-provisioner: v2.0.2 -> v2.2.2
  • csi-snapshotter: v2.1.3 -> v4.1.1

Also, removed preStop hook from node-driver-registrar container spec, as it's no longer needed: kubernetes-csi/node-driver-registrar#61

Special notes for reviewers:

In the light of current issues with CPO's CI infra, I've run the acceptance manually and everything seems to remain working just fine.

Release note:

[manila-csi-plugin] Updated sidecar versions: csi-node-driver-registrar v2.2.0, csi-provisioner v2.2.2, csi-snapshotter v4.1.1

gman0 added 3 commits August 10, 2021 12:29
@gman0
nodeplugin DaemonSet: removed preStop hook in node-driver-registrar
2cb8f01 
This was used to remove the registration socket when the container
node-driver-registrar container stops. As of [1] it's done by
the registrar itself, making this hook not needed anymore.

[1] kubernetes-csi/node-driver-registrar#61
@gman0
bumped sidecar versions
bb1fe91 
* csi-node-driver-registrar: v1.3.0 -> v2.2.0
* csi-provisioner: v2.0.2 -> v2.2.2
* csi-snapshotter: v2.1.3 -> v4.1.1
@gman0
bumped chart version
22410e3
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 10, 2021
@k8s-ci-robot k8s-ci-robot requested review from adisky and ricolin August 10, 2021 10:40
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 10, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 10, 2021

Build succeeded.

@gman0
Copy link
Member Author

gman0 commented Aug 10, 2021

PTAL @ramineni @gouthampacha @tombarron

@ramineni
Copy link
Contributor

@gman0 As discussed, our CI is not up yet, please run all the relevant tests manually and post the success results.

@ramineni
Copy link
Contributor

@gman0 Please update manifests as well https://github.com/kubernetes/cloud-provider-openstack/blob/master/manifests/manila-csi-plugin/

@ramineni ramineni added this to the release-1.22 milestone Aug 12, 2021
@gman0 gman0 mentioned this pull request Aug 12, 2021
Merged
@gman0
Copy link
Member Author

gman0 commented Aug 12, 2021

@ramineni I've updated the manifests too. Testing was done as a part of #1601 (comment)

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 12, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 12, 2021

Build succeeded.

@ramineni
Copy link
Contributor

/lgtm

1 similar comment
@ramineni
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2021
@gman0
Copy link
Member Author

gman0 commented Aug 13, 2021

I think we're missing approval for this PR.

@tombarron
Copy link
Contributor

/lgtm
/approve

Files are outside /pkg/csi/manila so this is just for the record

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tombarron
To complete the pull request process, please ask for approval from ramineni after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tombarron
Copy link
Contributor

@ramineni seems like this is ready for approval?

@lingxiankong
Copy link
Contributor

Given the current CI issue and the comments of the reviewers, I will manually merge this PR.

@lingxiankong lingxiankong merged commit 7bcf447 into kubernetes:master Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombarron tombarron tombarron approved these changes

@adisky adisky Awaiting requested review from adisky

@ricolin ricolin Awaiting requested review from ricolin

Assignees

@tombarron tombarron

@ramineni ramineni

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
release-1.22
Development

Successfully merging this pull request may close these issues.
5 participants
@gman0 @ramineni @tombarron @k8s-ci-robot @lingxiankong