Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] retry ubuntu image download on temp error #2505

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[tests] retry ubuntu image download on temp error #2505

merged 1 commit into from
Dec 14, 2023

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Dec 13, 2023

What this PR does / why we need it:

Quite frequently tests are failing because ubuntu image cannot be downloaded:

curl -sSL https://cloud-images.ubuntu.com/releases/jammy/release/ubuntu-22.04-server-cloudimg-amd64.img -o ubuntu-jammy.img
curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to cloud-images.ubuntu.com:443

This PR adds a retry

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 13, 2023
@k8s-ci-robot k8s-ci-robot requested review from dulek and zetaab December 13, 2023 20:07
@kayrus
Copy link
Contributor Author

kayrus commented Dec 13, 2023

cc @dulek @jiahuif @zetaab

@jeffyjf
Copy link
Contributor

jeffyjf commented Dec 14, 2023

LGTM, nice PR 👍

@jichenjc
Copy link
Contributor

/approve
/lgtm

great fix

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2c5c26c into kubernetes:master Dec 14, 2023
@kayrus kayrus deleted the test-image-download-retry branch December 14, 2023 11:18
@kayrus
Copy link
Contributor Author

kayrus commented Dec 14, 2023

/cherry-pick release-1.28

@k8s-infra-cherrypick-robot
Copy link

@kayrus: new pull request created: #2506

In response to this:

/cherry-pick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 14, 2023
Merged
@kayrus
Copy link
Contributor Author

kayrus commented Dec 14, 2023

/cherry-pick release-1.27

@kayrus
Copy link
Contributor Author

kayrus commented Dec 14, 2023

/cherry-pick release-1.26

@k8s-infra-cherrypick-robot
Copy link

@kayrus: new pull request created: #2507

In response to this:

/cherry-pick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 14, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@kayrus: new pull request created: #2508

In response to this:

/cherry-pick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulek dulek Awaiting requested review from dulek

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kayrus @jeffyjf @jichenjc @k8s-ci-robot @k8s-infra-cherrypick-robot