Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.30] [cinder-csi]: allow node service to run without openstack client #2656

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Sep 17, 2024

What this PR does / why we need it:

This PR allows to run cinder-csi-plugin node service without requiring the openstack credentials.

Which issue this PR fixes(if applicable):
fixes #2599
backport of the #2655

Special notes for reviewers:

This PR will be used to make backports to 1.29, 1.28

Release note:

This PR is intended to improve the cinder CSI driver security.

[cinder-csi]: allow node service to run without openstack client

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 17, 2024
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2024
@kayrus kayrus requested a review from dulek September 17, 2024 19:57
@zetaab
Copy link
Member

zetaab commented Sep 18, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2024
@kayrus
Copy link
Contributor Author

kayrus commented Sep 18, 2024

/cherry-pick release-1.29

@k8s-infra-cherrypick-robot

@kayrus: once the present PR merges, I will cherry-pick it on top of release-1.29 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kayrus
Copy link
Contributor Author

kayrus commented Sep 18, 2024

/cherry-pick release-1.28

@k8s-infra-cherrypick-robot

@kayrus: once the present PR merges, I will cherry-pick it on top of release-1.28 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 96dbb7b into kubernetes:release-1.30 Sep 18, 2024
6 checks passed
@k8s-infra-cherrypick-robot

@kayrus: #2656 failed to apply on top of branch "release-1.29":

Applying: allow node service to run without openstack client
Using index info to reconstruct a base tree...
M	cmd/cinder-csi-plugin/main.go
M	docs/cinder-csi-plugin/using-cinder-csi-plugin.md
M	pkg/csi/cinder/openstack/openstack.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/csi/cinder/openstack/openstack.go
Auto-merging docs/cinder-csi-plugin/using-cinder-csi-plugin.md
CONFLICT (content): Merge conflict in docs/cinder-csi-plugin/using-cinder-csi-plugin.md
Auto-merging cmd/cinder-csi-plugin/main.go
CONFLICT (content): Merge conflict in cmd/cinder-csi-plugin/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 allow node service to run without openstack client
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@kayrus: #2656 failed to apply on top of branch "release-1.28":

Applying: allow node service to run without openstack client
Using index info to reconstruct a base tree...
M	cmd/cinder-csi-plugin/main.go
M	docs/cinder-csi-plugin/using-cinder-csi-plugin.md
M	pkg/csi/cinder/openstack/openstack.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/csi/cinder/openstack/openstack.go
Auto-merging docs/cinder-csi-plugin/using-cinder-csi-plugin.md
CONFLICT (content): Merge conflict in docs/cinder-csi-plugin/using-cinder-csi-plugin.md
Auto-merging cmd/cinder-csi-plugin/main.go
CONFLICT (content): Merge conflict in cmd/cinder-csi-plugin/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 allow node service to run without openstack client
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kayrus
Copy link
Contributor Author

kayrus commented Sep 18, 2024

/cherry-pick release-1.29

@k8s-infra-cherrypick-robot

@kayrus: new pull request created: #2668

In response to this:

/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants