Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] improved readability of lb funcs, switch to slices.Contains #2688

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[core] improved readability of lb funcs, switch to slices.Contains #2688

merged 1 commit into from
Oct 16, 2024

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Oct 14, 2024

What this PR does / why we need it:

Fixed nested conditions logic and switched to slices.Contains, removed Contains func from util package.

Which issue this PR fixes(if applicable):

n/a

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 14, 2024
@kayrus kayrus requested a review from dulek October 14, 2024 16:51
zetaab
zetaab approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@kayrus
Copy link
Contributor Author

kayrus commented Oct 15, 2024

@zetaab @mdbooth can you add lgtm to merge this? I have yet another PR with further code improvements. And I believe I'll submit more. Last time when I tried to make code improvements in one PR, it didn't work.

@zetaab
Copy link
Member

zetaab commented Oct 16, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit dde74a1 into kubernetes:master Oct 16, 2024
11 checks passed
@kayrus kayrus deleted the lb-addr-logic branch October 16, 2024 08:18
@Lucasgranet Lucasgranet mentioned this pull request Nov 18, 2024
Closed
@kayrus kayrus mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@anguslees anguslees Awaiting requested review from anguslees

@dulek dulek Awaiting requested review from dulek

Assignees

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kayrus @k8s-ci-robot @zetaab