Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Create vcpctl tool framework. (Stage 1) #31

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Feature: Create vcpctl tool framework. (Stage 1) #31

merged 1 commit into from
Aug 20, 2018

Conversation

fanzhangio
Copy link

@fanzhangio fanzhangio commented Jul 31, 2018 •
edited
Loading

  • Add command and cli packageAdd vcpctl command and cli pacakge

#15

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 31, 2018
@k8s-ci-robot k8s-ci-robot requested review from imkin and luomiao July 31, 2018 10:51
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2018
@figo
Copy link
Contributor

figo commented Aug 7, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 7, 2018
Feature: Create vcpctl tool framework. (Phase 1)
1af405c 
- Add command and cli package
@fanzhangio fanzhangio changed the title [WIP] Feature: Create vcpctl tool framework to facilitate CCM provisioning Feature: Create vcpctl tool framework. (Phase 1) Aug 17, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2018
@fanzhangio fanzhangio changed the title Feature: Create vcpctl tool framework. (Phase 1) Feature: Create vcpctl tool framework. (Stage 1) Aug 17, 2018
@frapposelli
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frapposelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit b31be0b into kubernetes:master Aug 20, 2018
JoelSpeed pushed a commit to JoelSpeed/cloud-provider-vsphere that referenced this pull request Jul 17, 2023
@openshift-merge-robot
Merge pull request kubernetes#31 from openshift-cloud-team/update-owners
497af4e 
Update OWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imkin imkin Awaiting requested review from imkin

@luomiao luomiao Awaiting requested review from luomiao

Assignees

@frapposelli frapposelli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fanzhangio @figo @frapposelli @k8s-ci-robot