Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slack channel for csi-windows working group #4053

Closed
wants to merge 4 commits into from
Closed

Add slack channel for csi-windows working group #4053

wants to merge 4 commits into from

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Sep 4, 2019

The purpose of this channel is to set up a shared communication place
for the working group on supporting CSI windows

The proposal for enhancements to support CSI plugins on Windows nodes is
here kubernetes/enhancements#1141

@jingxu97
Add slack channel for csi-windows working group
a41978d 
The purpose of this channel is to set up a shared communication place
for the working group on supporting CSI windows

The proposal for enhancements to support CSI plugins on Windows nodes is
here kubernetes/enhancements#1141
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2019
@k8s-ci-robot k8s-ci-robot added area/community-management area/slack-management Issues or PRs related to the Slack Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Sep 4, 2019
@jingxu97
Copy link
Contributor Author

jingxu97 commented Sep 4, 2019

cc @ddebroy @pjh

@pjh
Copy link

pjh commented Sep 4, 2019

LGTM!
cc @wk8

@wk8
Copy link

wk8 commented Sep 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2019
@mrbobbytables
Copy link
Member

/hold
Holding for sig-storage channel delegation / csi channel rename 👍
ref: #4060

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2019
@mrbobbytables
Copy link
Member

Now that #4060 has merged. Would you mind adding it to the sig-storage config as csi-windows? 😄

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2019
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jingxu97
To complete the pull request process, please assign alejandrox1
You can assign the PR to them by writing /assign @alejandrox1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@mrbobbytables
Copy link
Member

Ah, sorry -- I should have been more clear -- it should now be added to:
communication/slack-config/sig-storage/config.yaml
The csi-* channels have been delegated so that the sig-storage-leads can approve 👍

@jingxu97
Copy link
Contributor Author

jingxu97 commented Sep 6, 2019

close this one, please review the new one #4064

@jingxu97 jingxu97 closed this Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdumars jdumars Awaiting requested review from jdumars

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@wk8 wk8

Labels
area/community-management area/slack-management Issues or PRs related to the Slack Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jingxu97 @pjh @wk8 @mrbobbytables @k8s-ci-robot