Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Plugin resources, and docs #7732

Merged
merged 1 commit into from
May 15, 2023

Conversation

frozenprocess
Copy link
Contributor

Temporary fix for #4598

  • Experimental annotation until we can sort out the approval. More here
  • Url in docs pointing to the right resource

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: frozenprocess / name: Reza Ramezanpour (9f2aac1)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 13, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @frozenprocess!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 13, 2023
* Experimental annotation until we can sort out the approval. kedacore/keda#552
* Url in docs pointing to the right resource
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frozenprocess, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #7732 (66bf0dc) into master (7708a81) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7732   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files         218      218           
  Lines       12099    12099           
  Branches      179      179           
=======================================
  Hits         5105     5105           
  Misses       6709     6709           
  Partials      285      285           

@k8s-ci-robot k8s-ci-robot merged commit a60dd67 into kubernetes:master May 15, 2023
@frozenprocess frozenprocess deleted the plugin_update branch May 15, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants