Skip to content

Commit

Permalink
Merge pull request #4260 from bart0sh/PR013-DRA-non-graceful-node-shu…
Browse files Browse the repository at this point in the history
…tdowns

DRA: handle non graceful node shutdowns
  • Loading branch information
k8s-ci-robot authored Oct 19, 2023
2 parents 19975ac + aa42236 commit 0d9f0c4
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions keps/sig-node/3063-dynamic-resource-allocation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ SIG Architecture for cross-cutting KEPs).
- [Coordinating resource allocation through the scheduler](#coordinating-resource-allocation-through-the-scheduler)
- [Resource allocation and usage flow](#resource-allocation-and-usage-flow)
- [Scheduled pods with unallocated or unreserved claims](#scheduled-pods-with-unallocated-or-unreserved-claims)
- [Handling non graceful node shutdowns](#handling-non-graceful-node-shutdowns)
- [API](#api)
- [resource.k8s.io](#resourcek8sio)
- [core](#core)
Expand Down Expand Up @@ -1162,6 +1163,20 @@ Once all of those steps are complete, kubelet will notice that the claims are
ready and run the pod. Until then it will keep checking periodically, just as
it does for other reasons that prevent a pod from running.

### Handling non graceful node shutdowns

When a node is shut down unexpectedly and is tainted with an `out-of-service`
taint with NoExecute effect as explained in the [Non graceful node shutdown KEP](https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2268-non-graceful-shutdown),
all running pods on the node will be deleted by the GC controller and the
resources used by the pods will be deallocated. However, they will not be
un-prepared as the node is down and Kubelet is not running on it.

Resource drivers should be able to handle this situation correctly and
should not expect `UnprepareNodeResources` to be always called.
If resources are unprepared when `Deallocate` is called, `Deallocate`
might need to perform additional actions to correctly deallocate
resources.

### API

The PodSpec gets extended. To minimize the changes in core/v1, all new types
Expand Down

0 comments on commit 0d9f0c4

Please sign in to comment.