Skip to content

Commit

Permalink
Update 20190120-execution-hook-design.md
Browse files Browse the repository at this point in the history
  • Loading branch information
jingxu97 authored and xing-yang committed Apr 30, 2019
1 parent 16550b8 commit c2f1b5d
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion keps/sig-storage/20190120-execution-hook-design.md
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ type HookError struct {
// +optional
Reason *string
// It indicates when the error occured
// It indicates when the error occurred
// +optional
Timestamp *int64
}
Expand Down Expand Up @@ -253,6 +253,12 @@ type HookAction struct {
// If execution fails, the execution hook controller will keep retrying until reaching
// ActionTimeoutSeconds. If execution still fails or hangs, execution hook controller
// stops retrying and updates executionhook status to failed.
// If controller loses its state, counter restarts. In this case, controller will retry
// for at least this long, before stopping.
// Once an action is started, controller has no way to stop it even if
// ActionTimeoutSeconds is exceeded. This simply controls if retry happens or not.
// retry is based on exponential backoff policy. If ActionTimeoutSeconds is not
// specified, it will retry until the hook object is deleted.
// +optional
ActionTimeoutSeconds *int64
}
Expand Down

0 comments on commit c2f1b5d

Please sign in to comment.