New unique logging meta-data into key Kubernetes logs

[hase1128]

Enhancement Description

• One-line enhancement description (can be used as a release note): This KEP proposes a method for adding new three unique logging meta-data into K8s component logs.
• Kubernetes Enhancement Proposal: Trace context propagation #2312
• Primary contact (assignee): @hase1128
• Responsible SIGs: sig-instrumentation
• Reviewers: @serathius
• Approver: @dashpole
• Enhancement target (which target equals to which milestone):
  • Alpha release target (1.20)
  • Beta release target (x.y)
  • Stable release target (x.y)

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

[hase1128]

/sig instrumentation
/milestone v1.20

[k8s-ci-robot]

@hase1128: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/sig instrumentation
/milestone v1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zhijianli88]

/cc

[fenggw-fnst]

/cc

[johnbelamaric]

/milestone v1.20

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @hase1128 !

Enhancements Lead here, do you still intend to target this for alpha in 1.20?

Thanks!
Kirsten

[hase1128]

@kikisdeliveryservice

I would like to aim for 1.20 if possible, but 1.21 may be appropriate in terms of time.

[kikisdeliveryservice]

Hi @hase1128

We will track for now and you can just keep us updated.

[kikisdeliveryservice]

As a note I left some comments on your KEP PR that will need to be resolved as well: #1961 (review)

[ehashman]

Assuming the KEP is completed and approved, we will target 1.20; otherwise this will slip to 1.21 for alpha.

[kikisdeliveryservice]

Assuming the KEP is completed and approved, we will target 1.20; otherwise this will slip to 1.21 for alpha.

Great. We are tracking it for now, let us know if anything changes. As a note Enhancements Freeze is October 6th and the KEP will need to be merged, implementable (it's currently provisional) as well as have test plans and graduation criteria added. Would also be good to fill out the PRR.

[kinarashah]

Hi @hase1128,

Enhancement shadow for 1.20 release here 👋. As we're moving close to the Enhancement Freeze deadline (October 6), just wanted to remind you to update KEP PR.

We're looking for the KEP PR to have the following before this deadline:

• should have test plans
• should have graduation criteria
• should have state implementable and merged

Please let me know if you have any questions, thank you!

[kikisdeliveryservice]

@ehashman @hase1128 :

Has this slipped to 1.21? the kep update seems to say so: https://github.com/kubernetes/enhancements/pull/1961/files#diff-168484bdbc7e288639cb3b3a8cfc7552

[hase1128]

I think it will be 1.21.

[kikisdeliveryservice]

I think it will be 1.21.

Thanks for the update!

/milestone clear

[ehashman]

Ack from SIG Instrumentation leads/regular meeting on pushing to 1.21.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[gracenng]

Hi @zhijianli88 👋 1.22 Enhancement Shadow here

This enhancement is in good shape, just some minor change requests light of Enhancement Freeze on Thursday May 13th:

• In kep.yaml, latest-milestone is not updated to 1.22
• In kep.yaml, milestone does not match current stage
• KEP status is currently provisional instead of implementable

Thanks! 😊

[gracenng]

Hi @zhijianli88 👋 1.22 Enhancements shadow here.
I just wanted to double check to see if SIG-Instrumentation will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

[zhijianli88]

Hi @zhijianli88 1.22 Enhancements shadow here.
I just wanted to double check to see if SIG-Instrumentation will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

Seems we cannot catch up 1.22 since some misgivings in our KEP have not got resolved and consensus. I would greatly appreciate it if you kindly give me some feedback.

[gracenng]

Hi @zhijianli88, not sure if I understand your question, but it looks like you only need to make some minor changes I mentioned above and get your KEP PR merged to master.

If you are unable to merge in time for 1.22 Enhancement Freeze tomorrow, you have the option to file for an exception or update your KEP for the future releases.

Let me know if this answers your questions and if I can help in any way

[zhijianli88]

but it looks like you only need to make some minor changes I mentioned above and get your KEP PR merged to master.

Thanks for your help. I guess I got your point. of cause i will update the kep.yaml as your mentioned above later becuase they are out of day. but the key point is the design in this KEP have not get approved by community. So I'd like to shift to 1.23 instead.

[ehashman]

/milestone v1.23

Thanks!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[dashpole]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[ehashman]

/milestone clear

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[ehashman]

This may be superseded by #3077 which has similar goals.

[pohly]

Perhaps not superseded because nothing in that proposal will be specifically about trace IDs. But it should indeed provide the necessary logging infrastructure for this enhancement here.

[dashpole]

See #1961 (review). This enhancement was designed to be complementary to contextual logging.

[KobayashiD27]

to achieve our goal, we planned this 2 steps.

• object tracing, picked up after original Tracing KEP reduced scope
• adding context information to logs

contextual logging #3077 helps "adding context information to logs" and propagates trace context in one component.
And we should focus on the propagation between a component and other component in our KEP.

This is my understanding about the positions of our KEP and #3078. Does this fit your (and SIG-instrumentation's) understanding? @dashpole @pohly

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.