Add resize support for FlexVolume

[xingzhou]

Feature Description

• One-line feature description (can be used as a release note): Add resize call support for FlexVolume to support volume resizing like LVM expansion
• Primary contact (assignee): Tom Xing(@xingzhou)
• Responsible SIGs: sig-storage
• Design proposal link (community repo): Proposal for growing FlexVolume size. community#1700
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @gnufied & @chakri-nelluri
• Approver (likely from SIG/area to which feature belongs): TBD
• Feature target (which target equals to which milestone):
  • Alpha release target 1.13
  • Beta release target TBD
  • Stable release target TBD

[xingzhou]

According to the discussion in kubernetes/community#657, we want to add volume resize support for FlexVolume, including:
• Improve FlexVolume to support volume resizing call
• Support LVM volume expansion
/cc @gnufied, this feature request depends on #284

[gnufied]

Also we would want @chakri-nelluri as reviewer. Because he is primary author of flex.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[xingzhou]

We are starting to write a proposal doc first at:
https://docs.google.com/document/d/1dwom9xQ3Fg5F_jJrybr0slp-QsO3_CKiisxzNRoMhec/edit?usp=sharing

will update the progress then

[chakri-nelluri]

Thanks @xingzhou.
Reviewed and added comments.

[xingzhou]

Thanks @chakri-nelluri for the review, have responded with my answers, please take a look.

@saad-ali and @idvoretskyi, we are planning this feature for v1.10, would you please help to add this ticket to this milestone? thanks

[idvoretskyi]

/remove-lifecycle stale

[idvoretskyi]

@xingzhou added, thanks

cc @saad-ali @kubernetes/sig-storage-feature-requests

[chakri-nelluri]

@xingzhou Added few more comments. PTAL when you get a chance.

[gnufied]

@xingzhou it might be a good time today to move the proposal to community repository . I am not sure if everyone has seen the proposal on Google doc.

[xingzhou]

@gnufied, yes, I'll update the doc on async call and ExpandFS part, later will move the proposal to community repo

[xingzhou]

have moved the proposal doc to community repo, please take a look, thanks.

[gnufied]

@xingzhou can you link the design proposal in this feature description?

[aniket-s-kulkarni]

@guineveresaenger @kacole2 - We trying our best to get this in. There were some late coming review comments that have dragged this PR out.

The discussions currently underway are around relatively small portions of the code, the main code as well as e2e tests added have been completed and successful. I remain confident that this PR would be completed by the 11/15 code freeze.

[guineveresaenger]

Thank you for the update @aniket-s-kulkarni!

[claurence]

Hi @aniket-s-kulkarni - I'm an enhancements shadow checking in on how this issue is tracking. Code slush is on 11/9 and code freeze is coming up on 11/15 do you have a status update on the likelihood that this will make the the code freeze date?

[aniket-s-kulkarni]

@claurence the PR was merged in last week. There is a documentation PR open that I will comment on today so that would be on its way as well.

[AishSundar]

@aniket-s-kulkarni I assume this enhancement is done (except pending docs?)

[aniket-s-kulkarni]

@AishSundar yes that's correct. I think we can close this.

[aniket-s-kulkarni]

/close

[k8s-ci-robot]

@aniket-s-kulkarni: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AishSundar]

/reopen

@aniket-s-kulkarni thanks for conforming all work pertaining to Alpha in 1.13 is done. But we would like to keep this enhancement issue open for tracking through Beta and GA in future milestones.

[aniket-s-kulkarni]

@AishSundar OK I see.

[claurence]

@xingzhou Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP - I can not find a KEP for this issue, can you please drop a link for the KEP. Thanks

[claurence]

@xingzhou since there is no KEP for this issue yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

[aniket-s-kulkarni]

@claurence, I added this support as a part of 1.13 in the last cycle. The feature is still in beta and in this cycle I don't think we are planning any changes.

[kacole2]

Hello @aniket-s-kulkarni @xingzhou , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. This will also require a KEP to be included.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

[kacole2]

Hi @aniket-s-kulkarni @xingzhou , I'm the 1.16 Enhancement Lead/Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[gnufied]

I am going to close this feature because feature was implemented and it does not have a feature gate of its own. It will go GA along with general volume expansion feature which is tracked here - #284

/close

[k8s-ci-robot]

@gnufied: Closing this issue.

In response to this:

I am going to close this feature because feature was implemented and it does not have a feature gate of its own. It will go GA along with general volume expansion feature which is tracked here - #284

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.